Fix error message passing in Server::Start #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
approved these changes
Jan 15, 2023
tisonkun
reviewed
Jan 15, 2023
For example, before the PR, the error message in this line can never be dumped into log. So users can hardly know why the server fail to start. |
tisonkun
approved these changes
Jan 15, 2023
|
Merging... |
tisonkun
reviewed
Jan 15, 2023
| @@ -319,8 +319,7 @@ int main(int argc, char *argv[]) { | |||
| uint32_t ports[] = {config.port, config.tls_port, 0}; | |||
| for (uint32_t *port = ports; *port; ++port) { | |||
| if (Util::IsPortInUse(*port)) { | |||
| LOG(ERROR) << "Could not create server TCP since the specified port[" << *port << "] is already in use" | |||
| << std::endl; | |||
| LOG(ERROR) << "Could not create server TCP since the specified port[" << *port << "] is already in use"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.